Skip to content

feat: gettin production ready - #5

Merged
DatL4g merged 40 commits into
masterfrom
jirikuchynka/gettin-production-ready
Aug 11, 2025
Merged

feat: gettin production ready#5
DatL4g merged 40 commits into
masterfrom
jirikuchynka/gettin-production-ready

Conversation

@Anty0

@Anty0 Anty0 commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Changes:

  • Modified public API to match our existing SDKs better
  • Implement caching of strings pulled from CDN—when the internet is unavailable
  • Removed support for tolgee-cli in gradle-plugin - will be added back once we can make binary releases of tolgee-cli (to avoid the whole process of getting users to install the node version of tolgee-cli globally themselves)
  • Updated demo apps to match the new API
  • Created demo apps for showcasing the compiler-plugin features
  • Code refactoring and simplification
  • Guidelines for Junie
  • Updated README

Anty0 added 30 commits June 19, 2025 13:32
@Anty0
chore: add junie guidelines
9866f5d
@Anty0
refactor: getting ready for production - part 1
e4e206d 
- remove tolge-cli fallback from gradle plugin
- refactor the compiler plugin to avoid repeating code
- codebase cleanup
@Anty0
refactor: public api for Tolgee instance
fb9cae3
@Anty0
refactor: provide non-nullable singleton instance
62cc689
@Anty0
refactor: better match naming of Context extensions
0e2983b
@Anty0
refactor: deduplicate visit function
14ac5ca
@Anty0
feat: add StorageProvider support + docs fixes
afd2385
@Anty0
feat: implemented storage
3401b35
@Anty0
feat: remove tolgee-cli gradle plugin for now
00c3091
@Anty0
chore: missing doc
f34d3ce
@Anty0
chore: update demo applications
cc51b80
@Anty0
fix: update api description
7c3e189
@Anty0
fix: proper order of storage handling - prefer fresh
1dd3050
@Anty0
feat: CDN and .tolgeerc for examples
47d0ba6
@Anty0
feat: add language change to android demo
40cfbdf
@Anty0
feat: compiler demo + fixes
a416db3
@Anty0
feat: demo fixups, remove flow demo
d38f8be
@Anty0
feat: android jetpack demo
7b9b764
@Anty0
feat: bit more docs within demos
35ef3ce
@Anty0
feat: plurals support Sprintf format + plurals params fixes
708690e
@Anty0
feat: rename root module and repository
fb7178e
@Anty0
feat: update package/namespace name + update version
b64bf8b
@Anty0
feat: update README + rollback version + small fixes
7e135e3
@Anty0
fix: update compiler plugin group id
a0b668e
@Anty0
chore: add Tolgee mouse to readme
ebdce57
@Anty0
chore: update contributing with link to guidelines + add contributors…
11230b4 
… section
@Anty0
fix: update api spec
cd83e74
@Anty0
chore: fix guidelines link name
f246278
@Anty0
fix: imports for compose multiplatform demo
51c9e09
@Anty0
fix: typo in package name
b1b444e
@Anty0
Anty0 marked this pull request as ready for review August 4, 2025 17:01
@Anty0
Anty0 requested a review from DatL4g as a code owner August 4, 2025 17:02
DatL4g
DatL4g requested changes Aug 4, 2025
View reviewed changes

@DatL4g DatL4g left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but needs some small adjustments.

We should update all dependencies after merging before publishing.
And we can switch from NativeCoroutines to SKIE which comes with several improvements.

Comment thread core/src/androidMain/kotlin/io/tolgee/TolgeeResources.kt Outdated
Comment thread core/src/appleMain/kotlin/io/tolgee/TolgeeApple.kt Outdated
Comment thread core/src/commonMain/kotlin/io/tolgee/common/ExtendParser.kt Outdated
Comment thread core/src/commonMain/kotlin/io/tolgee/storage/TolgeeStorageProvider.kt Outdated
Comment thread core/src/commonMain/kotlin/io/tolgee/Tolgee.kt Outdated
Comment thread core/src/androidMain/kotlin/io/tolgee/storage/TolgeeStorageProviderAndroid.kt Outdated
Comment thread core/src/commonMain/kotlin/io/tolgee/Tolgee.kt
Comment thread core/src/commonMain/kotlin/io/tolgee/Tolgee.kt
Comment thread demo/exampleandroid/src/main/AndroidManifest.xml
Comment thread demo/examplejetpack/src/main/AndroidManifest.xml
@Anty0

Anty0 commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thanks for the review! Good points ^^
Time to fix them up and get ready for release. Docs and all the other small preparation steps are almost ready!

DatL4g
DatL4g reviewed Aug 5, 2025
View reviewed changes

@DatL4g DatL4g left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove these from the docs again.
This permission is added automatically when the library is added. (https://github.com/tolgee/tolgee-mobile-kotlin-sdk/blob/master/core/src/androidMain/AndroidManifest.xml)

<uses-permission android:name="android.permission.INTERNET" />

Only network security config is required

@amusejfo

amusejfo commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown

@Anty0 @DatL4g Hey we are currently in the midst of trying to implement tolgee for KMP for production, any chance this could be expedited?

@Anty0

Anty0 commented Aug 11, 2025

Copy link
Copy Markdown
Member Author

@amusejfo Hi! Sorry, I have been on vacation since Wednesday.
If we don't hit any roadblocks, we plan to release the first version by tomorrow. Feel free to test it out, and don't forget to let us know if you have any feedback!

@DatL4g

DatL4g commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator

LGTM

@DatL4g
DatL4g merged commit 8658968 into master Aug 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JanCizmar JanCizmar JanCizmar left review comments
@DatL4g DatL4g DatL4g requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Anty0 @amusejfo @DatL4g @JanCizmar